Commit Graph

2352 Commits

Author SHA1 Message Date
Joonas Rikkonen
027cebafdd Fixed the previously selected location staying selected but start button staying disabled when returning to the lobby screen in SP campaign. Made it impossible to progress without restarting if there were no other selectable locations. Closes #553 2018-08-01 14:09:22 +03:00
Joonas Rikkonen
5a6a8e2501 Wifi components can't communicate with the enemy sub in combat missions. Fixes #554 2018-08-01 13:52:47 +03:00
Joonas Rikkonen
82103cf394 Controllers don't have to be wired directly to an item for camera focus to work (= railguns and cameras can be used over wifi). Closes #535 2018-07-31 15:03:20 +03:00
Joonas Rikkonen
d81ee1a27e Added a bunch of checks to make sure a normalized zero vector (= NaN, NaN) is not used in any position/velocity/movement calculations. There were at least three places where it was causing problems according to error reports: when a character that can't enter a sub spawns at the center of a hull and when using an underwater scooter or throwing something while the cursor is at the position of the character, but there were tons of other places as well where it may have potentially caused physics errors. 2018-07-31 12:28:04 +03:00
Joonas Rikkonen
d881a7060b Updated tutorial info text to match the new color of the sonar display. Closes #550 2018-07-31 10:41:41 +03:00
Joonas Rikkonen
13a2e4d33b StatusEffect.StopAll clears DurationList and DelayList. Closes #543 2018-07-30 20:02:56 +03:00
Joonas Rikkonen
86df5f6b1a Physics error checks & logging 2018-07-30 14:31:30 +03:00
Joonas Rikkonen
7acd3f746d StatusEffects don't attempt to use removed items or apply property values to removed entities. 2018-07-30 14:30:27 +03:00
Joonas Rikkonen
b4d0a1bd38 Inventory sync fix (component index included in events created when the server receives an inventory update from a client). 2018-07-30 14:28:04 +03:00
Joonas Rikkonen
60a563fe75 EntityEvent fixes:
- Clients wait for midround syncing to finish before applying the remote state to connection panels and inventories (because the wires connected to the connection panel or items in the inventory may not exist before the EntitySpawner events have been received).
- Server writes 0 as the projectile ID if the projectile doesn't exist anymore when a Turret event is sent.
- More info in networkevent error messages.
2018-07-30 13:35:26 +03:00
Joonas Rikkonen
8c598db10b Fixed errors in RespawnManager.ClientRead when not using a shuttle, extra diving gear does not spawn when respawning in main sub (TODO: automatically give and equip diving gear if the sub is flooded?) 2018-07-30 11:41:54 +03:00
Joonas Rikkonen
c66098ca4e Fixed only the first inventory of an item being synced (e.g. clients wouldn't get notified when an item is contained in the "output inventory" of a fabricator or deconstructor). 2018-07-30 11:00:21 +03:00
Joonas Rikkonen
9964923eba Fixed server writing invalid item network events incorrectly (NetBuffer.Position is the read position, not write position) 2018-07-30 10:46:52 +03:00
Joonas Rikkonen
5233b51e18 More error checks in Item.ServerWrite 2018-07-30 10:12:55 +03:00
Joonas Rikkonen
458c972580 More server-side EntityEvent error logging, Item.ServerWrite does some error checks and writes NetEntityEvent.Type.Invalid as the type of the event instead of attempting to write a potentially unreadable message. 2018-07-29 22:28:56 +03:00
Joonas Rikkonen
b7b033dac1 Made the traitorlist command usable by clients (assuming they have the permission to use it). Closes #539 2018-07-29 21:16:59 +03:00
Joonas Rikkonen
6209f48fff More error logging to diagnose invalid header errors 2018-07-27 16:11:19 +03:00
Joonas Rikkonen
891a2c3257 Merge branch 'master' of https://github.com/Regalis11/Barotrauma 2018-07-27 11:14:14 +03:00
Joonas Rikkonen
5b019621b7 Fixed sea floor having a wrong collision category, causing artifacts to spawn below it. Closes #532 2018-07-27 11:14:09 +03:00
Joonas Rikkonen
2de1b2a05c v0.8.1.10 2018-07-27 02:30:35 +03:00
Joonas Rikkonen
ce18309a78 Fixed crashing when attempting to increase buy quantity in campaign UI when money is at zero, fixed capping the number input to the value the player can afford (the previous calculation only clamped it above zero). Closes #531 2018-07-26 16:42:11 +03:00
Joonas Rikkonen
90f6d351e5 Fixed indentation in jobs.xml, oxygengenerator.xml & weapons.xml and removed the oxygenite tank statuseffect that does nothing from oxygen generator 2018-07-26 13:09:54 +03:00
Joonas Rikkonen
50603b72f4 Fixed another bug in DockingPort that caused entity ID mismatches. Even though the server sent the IDs of the CURRENT hulls and gap of the docking port, they are not necessarily created in the correct order during midround syncing and may end up replacing the ID of another entity or another entity spawned after them may cause their IDs to be replaced. Closes #530 2018-07-26 12:42:29 +03:00
Joonas Rikkonen
b309b45246 Fixed entity ID mismatches and desync kicks caused by gap creation/removal in Structure.SetDamage. Creating the gaps on damaged walls wasn't guaranteed to happen in the same order client-side as on the server, causing the IDs to get assigned mismatching IDs and in some cases also affecting the IDs of other types of entities (see #528).
Now the structure gaps simply don't have IDs. They're never accessed by ID so I don't think there's the need to make the creation/removal go through entityspawner.
2018-07-25 17:34:10 +03:00
Joonas Rikkonen
40f4e94613 Fixed incorrect debug info when receiving a message with an invalid object header. The method wrote the bytes/bits read SINCE the previous object (= just one byte, the invalid object header) instead of what was read in the previous object. The error message also ignored empty entity events. 2018-07-25 17:00:31 +03:00
Joonas Rikkonen
d3d842eecd Added error checking and logging to wire cloning logic in MapEntity.Clone (see #527) 2018-07-25 11:49:10 +03:00
Joonas Rikkonen
01e97fe4bd Fixed crashing if the server attempts to spawn extra cargo that doesn't spawn in a container. 2018-07-24 19:10:18 +03:00
Joonas Rikkonen
df720b67ba Fixed clients getting desynced if cargomanager spawns extra containers due to running out of space. 2018-07-24 19:02:56 +03:00
Joonas Rikkonen
2705eddd18 Merge branch 'ursinewalrus-gameFailsToStartOnStoreOverBuy' 2018-07-24 18:39:16 +03:00
Joonas Rikkonen
9edbbaa170 Revert changes to the revolver sprite because jaggies are ugly 2018-07-24 16:41:14 +03:00
Joonas Rikkonen
8c2c517f74 Merge pull request #501 from BlueTheKing/master
Revolver, Plasma Cutter, Oxygen Generator, Oxygenite Tank changed
2018-07-24 16:28:22 +03:00
Joonas Rikkonen
756278bb81 Increased the minimum distance between verts in level collider generation code. Should make the "invalid triangle created by CaveGenerator" errors less frequent. (See #311) 2018-07-24 15:43:26 +03:00
Joonas Rikkonen
e21b756f29 Fixed invalid left/right normal errors during level generation (I think). The voronoi cell generation logic ignored zero-length edges, but it was possible for an edge to be so short that the distance from the adjacent edge to the center of the short edge rounded down to zero in GenerateWallShapes. 2018-07-24 15:00:35 +03:00
Joonas Rikkonen
bf0c12ce52 The number of completed missions in a level connection is saved (-> reloading doesn't reset the mission in the connection to the initial one). Fixes #517 2018-07-24 14:34:27 +03:00
Joonas Rikkonen
4a8845c604 Fixed docking ports creating duplicate hulls and gaps during loading 2018-07-24 13:21:36 +03:00
Joonas Rikkonen
5e6215a37c Fixed crashing when attempting to generate hulls with the "autohull" command when there are no walls or doors in the sub. 2018-07-24 13:21:02 +03:00
Joonas Rikkonen
65b8d2d36e Fixed door gaps being removed twice when unloading a sub (in door.Remove and Entity.RemoveAll). Probably didn't cause any issues other than unnecessary console warnings. 2018-07-24 13:19:07 +03:00
ursinewalrus
c28fd336c9 If you buy more than a full box worth of stuff at the store instead of not letting you start the mission it will put the extra stuff in extra boxes for you 2018-07-23 21:32:01 -05:00
ursinewalrus
4e3d375ae5 game will now launch on overbuy and extra items will be present on floor, however a GUI error will be generated on match start 2018-07-23 18:57:29 -05:00
Joonas Rikkonen
a63ee41e5f v0.8.1.9 2018-07-24 01:06:27 +03:00
Joonas Rikkonen
3b6bedb180 Fixed clients not recreating docking port hulls/gaps when receiving a network event if the docking port is already locked 2018-07-23 23:27:27 +03:00
Joonas Rikkonen
2c6535b1f2 PhysicsBody error messages are only shown in the console when verbose logging is on. 2018-07-23 22:52:24 +03:00
Joonas Rikkonen
852fc174c2 Fixes to respawn shuttle bugs that may have caused entity ID mismatches: clients don't remove gaps or undock docking ports when a respawn shuttle leaves the level (but instead receive network events that tell them to do so), removing gaps is done with EntitySpawner. 2018-07-23 22:51:52 +03:00
Joonas Rikkonen
002e63f1eb Fixed entity IDs occasionally getting messed up due to the gaps and hulls created by docking ports. Clients would simply use the existing hulls and gaps when a network event for an already docked port is received, even though they may have been removed and replaced with ones with different IDs. 2018-07-23 21:36:49 +03:00
Joonas Rikkonen
be5f168b76 Sending error messages during EntityEvent writing/reading and entity removal to GameAnalytics 2018-07-23 21:16:57 +03:00
Joonas Rikkonen
7977e47359 Fixes 2018-07-23 19:24:44 +03:00
Joonas Rikkonen
4b5a4d66e7 Fixed nullref exception if the player clicks yes on the "download sub from the server" prompt after returning to the main menu. 2018-07-23 18:37:48 +03:00
Joonas Rikkonen
4041633eec Clamping velocity when correcting submarine position 2018-07-23 18:33:32 +03:00
Joonas Rikkonen
12c6a081a9 Fixed nullref exception in NetLobbyScreen when selecting a level seed that has no background sprite defined 2018-07-23 18:33:04 +03:00
Joonas Rikkonen
9d1c4f3efb Moved Submarine.ClientRead to the client project 2018-07-23 17:58:28 +03:00