Small rewrite of the Coroutine logic to stop it from going out of bounds and crashing.

Subsurface/Source/CoroutineManager.cs

@@ -56,17 +56,8 @@ namespace Barotrauma
         {
             Coroutines.RemoveAll(c => c == handle);
         }
-
+        private static bool IsDone(CoroutineHandle handle)
-        // Updating just means stepping through all the coroutines
-        public static void Update(float unscaledDeltaTime, float deltaTime)
         {
-            UnscaledDeltaTime = unscaledDeltaTime;
-            DeltaTime = deltaTime;
-
-            for (int i = Coroutines.Count-1; i>=0; i--)
-            {
-                CoroutineHandle handle = Coroutines[i];
-
             try
             {
                 if (handle.Coroutine.Current != null)
@@ -74,37 +65,40 @@ namespace Barotrauma
                     WaitForSeconds wfs = handle.Coroutine.Current as WaitForSeconds;
                     if (wfs != null)
                     {
-                            if (!wfs.CheckFinished(unscaledDeltaTime)) continue;
+                        if (!wfs.CheckFinished(UnscaledDeltaTime)) return false;
                     }
                     else
                     {
                         switch ((CoroutineStatus)handle.Coroutine.Current)
                         {
                             case CoroutineStatus.Success:
-                                    Coroutines.RemoveAt(i);
+                                return true;
-                                    continue;
+
                             case CoroutineStatus.Failure:
                                 DebugConsole.ThrowError("Coroutine ''" + handle.Name + "'' has failed");
-                                    continue;
+                                return true;
                         }
                     }
                 }
 
                 handle.Coroutine.MoveNext();
+                return false;
             }
-
             catch (Exception e)
             {
                 DebugConsole.ThrowError("Coroutine " + handle.Name + " threw an exception: " + e.Message);
-
+                return true;
-//#if DEBUG
-//                    throw e;
-//#endif
-
-                    Coroutines.Remove(handle);
             }
-
         }
+        // Updating just means stepping through all the coroutines
+        public static void Update(float unscaledDeltaTime, float deltaTime)
+        {
+            UnscaledDeltaTime = unscaledDeltaTime;
+            DeltaTime = deltaTime;
+
+            foreach (var x in Coroutines.ToList())
+                if(IsDone(x))
+                    Coroutines.Remove(x);
         }
     }