(acf0cb343) Fixes to EnableWorkShopItem: - Don't allow enabling if the item is not compatible with the user's version of Barotrauma or if it's a core package that's missing some required files. - Don't allow enabling if the item external files referenced in the content package are not found (e.g. if a mod uses vanilla files but the vanilla files aren't found).

Barotrauma/BarotraumaShared/Source/ContentPackage.cs

@@ -217,6 +217,7 @@ namespace Barotrauma
         {
             return corePackageRequiredFiles.All(fileType => Files.Any(file => file.Type == fileType));
         }
+
         public bool ContainsRequiredCorePackageFiles(out List<ContentType> missingContentTypes)
         {
             missingContentTypes = new List<ContentType>();
@@ -230,6 +231,25 @@ namespace Barotrauma
             return missingContentTypes.Count == 0;
         }
 
+        /// <summary>
+        /// Make sure all the files defined in the content package are present
+        /// </summary>
+        /// <returns></returns>
+        public bool VerifyFiles(out List<string> errorMessages)
+        {
+            errorMessages = new List<string>();
+            foreach (ContentFile file in Files)
+            {
+                if (!File.Exists(file.Path))
+                {
+                    errorMessages.Add("File \"" + file.Path + "\" not found.");
+                    continue;
+                }
+            }
+
+            return errorMessages.Count == 0;
+        }
+
         public static ContentPackage CreatePackage(string name, string path, bool corePackage)
         {
             ContentPackage newPackage = new ContentPackage()
@@ -398,6 +418,13 @@ namespace Barotrauma
                     return path == "Mods";
             }
         }
+        /// <summary>
+        /// Are mods allowed to install a file into the specified path. If a content package XML includes files
+        /// with a prohibited path, they are treated as references to external files. For example, a mod could include
+        /// some vanilla files in the XML, in which case the game will simply use the vanilla files present in the game folder.
+        /// </summary>
+        /// <param name="path"></param>
+        /// <returns></returns>
         public static bool IsModFilePathAllowed(string path)
         {
             while (true)
@@ -426,7 +453,7 @@ namespace Barotrauma
         {
             return Files.Where(f => f.Type == type).Select(f => f.Path);
         }
-
+        
         public static void LoadAll(string folder)
         {
             if (!Directory.Exists(folder))

Barotrauma/BarotraumaShared/Source/GameSettings.cs

@@ -604,13 +604,14 @@ namespace Barotrauma
             }
             foreach (ContentPackage contentPackage in SelectedContentPackages)
             {
+                bool packageOk = contentPackage.VerifyFiles(out List<string> errorMessages);
+                if (!packageOk)
+                {
+                    DebugConsole.ThrowError("Error in content package \"" + contentPackage.Name + "\":\n" + string.Join("\n", errorMessages));
+                    continue;
+                }
                 foreach (ContentFile file in contentPackage.Files)
                 {
-                    if (!System.IO.File.Exists(file.Path))
-                    {
-                        DebugConsole.ThrowError("Error in content package \"" + contentPackage.Name + "\" - file \"" + file.Path + "\" not found.");
-                        continue;
-                    }
                     ToolBox.IsProperFilenameCase(file.Path);
                 }
             }
@@ -970,13 +971,14 @@ namespace Barotrauma
 
             foreach (ContentPackage contentPackage in SelectedContentPackages)
             {
+                bool packageOk = contentPackage.VerifyFiles(out List<string> errorMessages);
+                if (!packageOk)
+                {
+                    DebugConsole.ThrowError("Error in content package \"" + contentPackage.Name + "\":\n" + string.Join("\n", errorMessages));
+                    continue;
+                }
                 foreach (ContentFile file in contentPackage.Files)
                 {
-                    if (!System.IO.File.Exists(file.Path))
-                    {
-                        DebugConsole.ThrowError("Error in content package \"" + contentPackage.Name + "\" - file \"" + file.Path + "\" not found.");
-                        continue;
-                    }
                     ToolBox.IsProperFilenameCase(file.Path);
                 }
             }