From d34cea51cf6d73810699905ffafd8519d0b8b4a4 Mon Sep 17 00:00:00 2001
From: peelz <peelz.dev@gmail.com>
Date: Fri, 12 Aug 2022 01:31:07 -0400
Subject: [PATCH] Fix workflow not reporting test results when ran from a PR

---
 .github/workflows/report-test-results.yml | 27 +++++++++++++++++++++++
 .github/workflows/run-tests.yml           | 14 +++++-------
 2 files changed, 33 insertions(+), 8 deletions(-)
 create mode 100644 .github/workflows/report-test-results.yml

diff --git a/.github/workflows/report-test-results.yml b/.github/workflows/report-test-results.yml
new file mode 100644
index 000000000..261cf723c
--- /dev/null
+++ b/.github/workflows/report-test-results.yml
@@ -0,0 +1,27 @@
+# yaml-language-server: $schema=https://json.schemastore.org/github-workflow.json
+
+name: Report test results
+
+# HACK: the "on-push-pr" workflow gets run with read-only perms.
+# This workflow will run in our repo with write permissions after
+# the PR checks are done running.
+on:
+  workflow_run:
+    workflows:
+      - On push to master branch
+      - On push to a secondary branch
+      - On push to a PR
+    types: [completed]
+
+jobs:
+  report-test-results:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Report test results
+        uses: dorny/test-reporter@v1
+        with:
+          name: Test results
+          artifact: test-results
+          path: test-results.trx
+          fail-on-error: false
+          reporter: dotnet-trx
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
index 1d7c3f22f..558ed45ea 100644
--- a/.github/workflows/run-tests.yml
+++ b/.github/workflows/run-tests.yml
@@ -33,7 +33,10 @@ jobs:
 
       - name: Run tests
         continue-on-error: true
-        run: dotnet test LinuxSolution.sln -clp:"ErrorsOnly;Summary" --logger "trx;LogFileName=$PWD/test-results.trx"
+        run: |
+          set +e
+          dotnet test LinuxSolution.sln -clp:"ErrorsOnly;Summary" --logger "trx;LogFileName=$PWD/test-results.trx"
+          echo "EXITCODE=$?" >> "$GITHUB_ENV"
 
       - name: Upload test results
         uses: actions/upload-artifact@v3
@@ -41,10 +44,5 @@ jobs:
           name: test-results
           path: test-results.trx
 
-      - name: Report test results
-        uses: dorny/test-reporter@v1
-        with:
-          name: Test results
-          path: test-results.trx
-          fail-on-error: true
-          reporter: dotnet-trx
+      - name: Set exit code
+        run: exit "$EXITCODE"