Readded special client permissions

Also added a command that requires a password to gain the permissions.
I think they were never vulnerable in the first place, gamerfood was just trying to intimidate us.

Subsurface/Source/DebugConsole.cs

@@ -6,6 +6,7 @@ using Microsoft.Xna.Framework.Graphics;
 using Microsoft.Xna.Framework.Input;
 using Barotrauma.Networking;
 using Barotrauma.Items.Components;
+using System.Text;
 
 namespace Barotrauma
 {
@@ -123,7 +124,6 @@ namespace Barotrauma
 
                 if (PlayerInput.KeyDown(Keys.Enter) && textBox.Text != "")
                 {
-                    NewMessage(textBox.Text, Color.White);
                     ExecuteCommand(textBox.Text, game);
                     textBox.Text = "";
 
@@ -165,6 +165,7 @@ namespace Barotrauma
                 case "netstats":
                 case "help":
                 case "dumpids":
+                case "admin":
                     return true;
                 default:
                     return false;
@@ -176,6 +177,10 @@ namespace Barotrauma
             if (string.IsNullOrWhiteSpace(command)) return;
             string[] commands = command.Split(' ');
             
+            if (!commands[0].ToLowerInvariant().Equals("admin"))
+            {
+                NewMessage(textBox.Text, Color.White);
+            }
 
 #if !DEBUG
             if (GameMain.Client != null && !IsCommandPermitted(commands[0].ToLowerInvariant(), GameMain.Client))
@@ -370,6 +375,17 @@ namespace Barotrauma
                 case "enablecrewai":
                     HumanAIController.DisableCrewAI = false;
                     break;
+                case "admin":
+                    if (GameMain.Server != null)
+                    {
+                        GameMain.Server.AdminAuthPass = commands[1];
+
+                    }
+                    else if (GameMain.Client != null)
+                    {
+                        GameMain.Client.RequestAdminAuth(commands[1]);
+                    }
+                    break;
                 case "kick":
                     if (GameMain.NetworkMember == null || commands.Length < 2) break;
                     GameMain.NetworkMember.KickPlayer(string.Join(" ", commands.Skip(1)), false);

Subsurface/Source/Networking/Client.cs

@@ -52,7 +52,7 @@ namespace Barotrauma.Networking
 
         public float deleteDisconnectedTimer;
 
-        public ClientPermissions Permissions;
+        public ClientPermissions Permissions = ClientPermissions.None;
         
         public int KickVoteCount
         {
@@ -129,7 +129,7 @@ namespace Barotrauma.Networking
 
         public bool HasPermission(ClientPermissions permission)
         {
-            return false; //Permissions.HasFlag(permission);
+            return this.Permissions.HasFlag(permission);
         }
 
         public T GetVote<T>(VoteType voteType)

Subsurface/Source/Networking/GameClient.cs

@@ -26,7 +26,7 @@ namespace Barotrauma.Networking
         private GUIButton endRoundButton;
         private GUITickBox endVoteTickBox;
 
-        private ClientPermissions permissions;
+        private ClientPermissions permissions = ClientPermissions.None;
 
         private bool connected;
 
@@ -839,7 +839,7 @@ namespace Barotrauma.Networking
 
         public bool HasPermission(ClientPermissions permission)
         {
-            return false;// permissions.HasFlag(permission);
+            return permissions.HasFlag(permission);
         }
 
         public override void Draw(Microsoft.Xna.Framework.Graphics.SpriteBatch spriteBatch)
@@ -1026,6 +1026,15 @@ namespace Barotrauma.Networking
             client.SendMessage(msg, NetDeliveryMethod.ReliableUnordered);
         }
 
+        public void RequestAdminAuth(string pass)
+        {
+            NetOutgoingMessage msg = client.CreateMessage();
+            msg.Write((byte)PacketTypes.RequestAdminAuth);
+            msg.Write(Encoding.UTF8.GetString(NetUtility.ComputeSHAHash(Encoding.UTF8.GetBytes(pass))));
+
+            client.SendMessage(msg, NetDeliveryMethod.ReliableUnordered);
+        }
+
         public override void KickPlayer(string kickedName, bool ban, bool range = false)
         {
             if (!permissions.HasFlag(ClientPermissions.Kick) && !ban) return;

Subsurface/Source/Networking/GameServer.cs

@@ -55,6 +55,8 @@ namespace Barotrauma.Networking
             name = name.Replace(":", "");
             name = name.Replace(";", "");
 
+            AdminAuthPass = "";
+
             this.name = name;
             this.password = "";
             if (password.Length>0)
@@ -551,6 +553,32 @@ namespace Barotrauma.Networking
                                 EndGame();
                             }
                             break;
+                        case (byte)PacketTypes.RequestAdminAuth:
+                            string pass = inc.ReadString();
+                            if (adminAuthPass.Length == 0)
+                            {
+                                Log(sender.name + " tried to become admin!", Color.Red);
+                                return;
+                            }
+                            if (adminAuthPass==pass)
+                            {
+                                if (sender.Permissions == ClientPermissions.None)
+                                {
+                                    Log(sender.name + " is now an admin.", Color.Yellow);
+                                    sender.SetPermissions(ClientPermissions.Kick | ClientPermissions.Ban | ClientPermissions.EndRound);
+                                }
+                                else
+                                {
+                                    Log(sender.name + " is no longer an admin.", Color.Yellow);
+                                    sender.SetPermissions(ClientPermissions.None);
+                                }
+                                UpdateClientPermissions(sender);
+                            }
+                            else
+                            {
+                                Log(sender.name + " has failed admin authentication!", Color.Red);
+                            }
+                            break;
                         case (byte)PacketTypes.KickPlayer:                            
                             bool ban = inc.ReadBoolean();
                             string kickedName = inc.ReadString();
@@ -561,7 +589,6 @@ namespace Barotrauma.Networking
                             if (ban && !sender.HasPermission(ClientPermissions.Ban))
                             {
                                 Log(sender.name + " attempted to ban " + kickedClient.name + " (insufficient permissions)", Color.Red);
-
                             }
                             else if (!sender.HasPermission(ClientPermissions.Kick))
                             {

Subsurface/Source/Networking/GameServerLogin.cs

@@ -198,6 +198,10 @@ namespace Barotrauma.Networking
             {
                 newClient.SetPermissions(savedPermissions.Permissions);
             }
+            else
+            {
+                newClient.SetPermissions(ClientPermissions.None);
+            }
 
             connectedClients.Add(newClient);
 

Subsurface/Source/Networking/GameServerSettings.cs

@@ -63,6 +63,20 @@ namespace Barotrauma.Networking
 
         private string password;
 
+        private string adminAuthPass = "";
+        public string AdminAuthPass
+        {
+            set
+            {
+                DebugConsole.NewMessage("Admin auth pass changed!",Color.Yellow);
+                adminAuthPass = "";
+                if (value.Length > 0)
+                {
+                    adminAuthPass = Encoding.UTF8.GetString(Lidgren.Network.NetUtility.ComputeSHAHash(Encoding.UTF8.GetBytes(value)));
+                }
+            }
+        }
+
         private GUIFrame settingsFrame;
         private GUIFrame[] settingsTabs;
         private int settingsTabIndex;

Subsurface/Source/Networking/NetworkMember.cs

@@ -19,6 +19,8 @@ namespace Barotrauma.Networking
 
         KickPlayer,
 
+        RequestAdminAuth,
+
         Permissions,
 
         RequestNetLobbyUpdate,