(a405d1aed) Check volume validity in SoundPlayer.UpdateWaterAmbience (there was a report on GameAnalytics about the method setting the gain to an invalid value) + Merge fix

2019-04-15 13:44:05 +03:00
parent 53f9202909
commit b8b61ebb02
7 changed files with 9 additions and 510 deletions
@@ -269,6 +269,13 @@ namespace Barotrauma
                }

                movementSoundVolume = Math.Max(movementSoundVolume, movementFactor);
+                if (!MathUtils.IsValid(movementSoundVolume))
+                {
+                    string errorMsg = "Failed to update water ambience volume - submarine's movement value invalid (" + movementSoundVolume + ", sub velocity: " + sub.Velocity + ")";
+                    DebugConsole.Log(errorMsg);
+                    GameAnalyticsManager.AddErrorEventOnce("SoundPlayer.UpdateWaterAmbience:InvalidVolume", GameAnalyticsSDK.Net.EGAErrorSeverity.Error, errorMsg);
+                    movementSoundVolume = 0.0f;
+                }
            }

            if (waterAmbiences.Count > 1)