(7e43eae73) Optimized Item.ApplyStatusEffects & ItemComponent.PlaySound: check if the item has effects/sounds of the correct type from a bool array instead of doing a dictionary lookup. A small thing, but the methods are called so frequently that it adds up to a lot.

Barotrauma/BarotraumaClient/Source/Items/Components/ItemComponent.cs

@@ -48,6 +48,7 @@ namespace Barotrauma.Items.Components
 
     partial class ItemComponent : ISerializableEntity
     {
+        private bool[] hasSoundsOfType;
         private Dictionary<ActionType, List<ItemSound>> sounds;
         private Dictionary<ActionType, SoundSelectionMode> soundSelectionModes;
 
@@ -183,6 +184,8 @@ namespace Barotrauma.Items.Components
         private SoundChannel loopingSoundChannel;
         public void PlaySound(ActionType type, Vector2 position, Character user = null)
         {
+            if (!hasSoundsOfType[(int)type]) { return; }
+
             if (loopingSound != null)
             {
                 if (Vector3.DistanceSquared(GameMain.SoundManager.ListenerPosition, new Vector3(position.X, position.Y, 0.0f)) > loopingSound.Range * loopingSound.Range)
@@ -224,10 +227,9 @@ namespace Barotrauma.Items.Components
                 }
                 return;
             }
-
-            if (!sounds.TryGetValue(type, out List<ItemSound> matchingSounds)) return;
-            
+                        
             ItemSound itemSound = null;
+            var matchingSounds = sounds[type];
             if (loopingSoundChannel == null || !loopingSoundChannel.IsPlaying)
             {
                 SoundSelectionMode soundSelectionMode = soundSelectionModes[type];
@@ -262,7 +264,7 @@ namespace Barotrauma.Items.Components
 
         private void PlaySound(ItemSound itemSound, Vector2 position, Character user = null)
         {
-            if (Vector3.DistanceSquared(GameMain.SoundManager.ListenerPosition, new Vector3(position.X, position.Y, 0.0f)) > itemSound.Range * itemSound.Range)
+            if (Vector2.DistanceSquared(new Vector2(GameMain.SoundManager.ListenerPosition.X, GameMain.SoundManager.ListenerPosition.Y), position) > itemSound.Range * itemSound.Range)
             {
                 return;
             }
@@ -451,6 +453,7 @@ namespace Barotrauma.Items.Components
                     {
                         soundList = new List<ItemSound>();
                         sounds.Add(itemSound.Type, soundList);
+                        hasSoundsOfType[(int)itemSound.Type] = true;
                     }
 
                     soundList.Add(itemSound);