Merge branch 'dev' of https://github.com/Regalis11/Barotrauma into unstable

Barotrauma/BarotraumaShared/SharedSource/Events/Missions/Mission.cs

@@ -348,11 +348,15 @@ namespace Barotrauma
             completed = 
                 DetermineCompleted() && 
                 (completeCheckDataAction == null ||completeCheckDataAction.GetSuccess());
-            if (Prefab.LocationTypeChangeOnCompleted != null)
+            if (completed)
             {
-                ChangeLocationType(Prefab.LocationTypeChangeOnCompleted);
+                if (Prefab.LocationTypeChangeOnCompleted != null)
+                {
+                    ChangeLocationType(Prefab.LocationTypeChangeOnCompleted);
+                }
+                GiveReward();
             }
-            GiveReward();
+
             EndMissionSpecific(completed);
         }
 

Barotrauma/BarotraumaShared/SharedSource/Items/Item.cs

@@ -3216,6 +3216,7 @@ namespace Barotrauma
             }
 #endif
 
+            item.condition = element.GetAttributeFloat("condition", item.condition);
             foreach (XAttribute attribute in (appliedSwap?.ConfigElement ?? element).Attributes())
             {
                 if (!item.SerializableProperties.TryGetValue(attribute.NameAsIdentifier(), out SerializableProperty property)) { continue; }

Barotrauma/BarotraumaShared/changelog.txt

@@ -1,3 +1,13 @@
+---------------------------------------------------------------------------------------------------------
+v0.19.9.0
+---------------------------------------------------------------------------------------------------------
+
+Fixes to new issues in the previous build:
+- Fixed missions always giving rewards even if you fail them!
+- Fixed clients sometimes failing to reconnect to the server if the connection is momentarily lost.
+- Fixed item conditions resetting to 100% between rounds.
+- Fixed mineral missions always causing a crash.
+
 ---------------------------------------------------------------------------------------------------------
 v0.19.8.0
 ---------------------------------------------------------------------------------------------------------