Unstable 0.17.1.0

2022-03-17 01:25:04 +09:00
parent 3974067915
commit 6d410cc1b7
302 changed files with 5878 additions and 3317 deletions
@@ -388,7 +388,7 @@ namespace Barotrauma
                        break;
                    }
                }
-                if (targetingTag == null)
+                if (targetingTag.IsNullOrEmpty())
                {
                    if (targetItem.GetComponent<Sonar>() != null)
                    {
@@ -2100,15 +2100,11 @@ namespace Barotrauma
                if (!ActiveAttack.IsRunning)
                {
 #if SERVER
-                    GameMain.NetworkMember.CreateEntityEvent(Character, new object[]
-                    {
-                        Networking.NetEntityEvent.Type.SetAttackTarget,
+                    GameMain.NetworkMember.CreateEntityEvent(Character, new Character.SetAttackTargetEventData(
                        attackingLimb,
-                        (damageTarget as Entity)?.ID ?? Entity.NullEntityID,
-                        damageTarget is Character character && targetLimb != null ? Array.IndexOf(character.AnimController.Limbs, targetLimb) : 0,
-                        SimPosition.X,
-                        SimPosition.Y
-                    });
+                        damageTarget,
+                        targetLimb,
+                        SimPosition));
 #else
                    Character.PlaySound(CharacterSound.SoundType.Attack, maxInterval: 3);
 #endif
@@ -2696,7 +2692,7 @@ namespace Barotrauma
                        float target = targetParams.Threshold;
                        if (targetParams.ThresholdMin > 0 && targetParams.ThresholdMax > 0)
                        {
-                            target = selectedTargetingParams == targetParams ? targetParams.ThresholdMax : targetParams.ThresholdMin;
+                            target = selectedTargetingParams == targetParams && State == AIState.FleeTo ? targetParams.ThresholdMax : targetParams.ThresholdMin;
                        }
                        if (Character.HealthPercentage > target)
                        {
@@ -569,7 +569,8 @@ namespace Barotrauma
                        (Character.Submarine.TeamID != Character.TeamID && !Character.IsEscorted) ||
                        ObjectiveManager.CurrentOrders.Any(o => o.Objective.KeepDivingGearOnAlsoWhenInactive) ||
                        ObjectiveManager.CurrentObjective.GetSubObjectivesRecursive(true).Any(o => o.KeepDivingGearOn) ||
-                        Character.CurrentHull.OxygenPercentage < HULL_LOW_OXYGEN_PERCENTAGE + 10;
+                        Character.CurrentHull.OxygenPercentage < HULL_LOW_OXYGEN_PERCENTAGE + 10 ||
+                        Character.CurrentHull.IsWetRoom;
                    bool IsOrderedToWait() => Character.IsOnPlayerTeam && ObjectiveManager.CurrentOrder is AIObjectiveGoTo goTo && goTo.Target == Character;
                    bool removeDivingSuit = !shouldKeepTheGearOn && !IsOrderedToWait();
                    if (oxygenLow && Character.CurrentHull.Oxygen > 0 && (!isCurrentObjectiveFindSafety || Character.OxygenAvailable < 1))
@@ -1265,15 +1266,15 @@ namespace Barotrauma
            {
                if (!IsFriendly(attacker))
                {
-                    if (Character.Submarine == null)
+                    if (c.Submarine == null)
                    {
                        // Outside
                        return attacker.Submarine == null ? AIObjectiveCombat.CombatMode.Defensive : AIObjectiveCombat.CombatMode.Retreat;
                    }
-                    if (!Character.Submarine.GetConnectedSubs().Contains(attacker.Submarine))
+                    if (!c.Submarine.GetConnectedSubs().Contains(attacker.Submarine))
                    {
                        // Attacked from an unconnected submarine.
-                        return Character.SelectedConstruction?.GetComponent<Turret>() != null ? AIObjectiveCombat.CombatMode.None : AIObjectiveCombat.CombatMode.Retreat;
+                        return c.SelectedConstruction?.GetComponent<Turret>() != null ? AIObjectiveCombat.CombatMode.None : AIObjectiveCombat.CombatMode.Retreat;
                    }
                    return c.AIController is HumanAIController humanAI &&
                        (humanAI.ObjectiveManager.IsCurrentOrder<AIObjectiveFightIntruders>() || humanAI.ObjectiveManager.Objectives.Any(o => o is AIObjectiveFightIntruders)) 
@@ -1285,18 +1286,22 @@ namespace Barotrauma
                    {
                        cumulativeDamage = 100;
                    }
-                    if (GameMain.IsSingleplayer && attacker.IsPlayer && Character.TeamID == attacker.TeamID)
+                    if (attacker.IsPlayer && c.TeamID == attacker.TeamID)
                    {
-                        // Bots in the player team never act aggressively in single player when attacked by the player
-                        return cumulativeDamage > minorDamageThreshold ? AIObjectiveCombat.CombatMode.Retreat : AIObjectiveCombat.CombatMode.None;
+                        if (GameMain.IsSingleplayer || Character.TeamID != attacker.TeamID)
+                        {
+                            // Bots in the player team never act aggressively in single player when attacked by the player
+                            // In multiplayer, they react only to players attacking them or other crew members
+                            return Character == c && cumulativeDamage > minorDamageThreshold ? AIObjectiveCombat.CombatMode.Retreat : AIObjectiveCombat.CombatMode.None;
+                        }
                    }
-                    if (Character.Submarine == null || !Character.Submarine.GetConnectedSubs().Contains(attacker.Submarine))
+                    if (c.Submarine == null || !c.Submarine.GetConnectedSubs().Contains(attacker.Submarine))
                    {
                        // Outside or attacked from an unconnected submarine -> don't react.
                        return AIObjectiveCombat.CombatMode.None;
                    }
                    // If there are any enemies around, just ignore the friendly fire
-                    if (Character.CharacterList.Any(ch => ch.Submarine == Character.Submarine && !ch.Removed && !ch.IsIncapacitated && !IsFriendly(ch) && VisibleHulls.Contains(ch.CurrentHull)))
+                    if (Character.CharacterList.Any(ch => ch.Submarine == c.Submarine && !ch.Removed && !ch.IsIncapacitated && !IsFriendly(ch) && VisibleHulls.Contains(ch.CurrentHull)))
                    {
                        isAttackerFightingEnemy = true;
                        return AIObjectiveCombat.CombatMode.None;
@@ -1352,18 +1357,19 @@ namespace Barotrauma

                    Character FindInstigator()
                    {
-                        if (Character.IsInstigator)
+                        if (attacker.IsInstigator)
                        {
-                            return Character;
+                            return attacker;
                        }
-                        else if (c.AIController is HumanAIController humanAi)
+                        if (c.IsInstigator)
+                        {
+                            return c;
+                        }
+                        if (c.AIController is HumanAIController humanAi)
                        {
                            return Character.CharacterList.FirstOrDefault(ch => ch.Submarine == c.Submarine && !ch.Removed && !ch.IsIncapacitated && ch.IsInstigator && humanAi.VisibleHulls.Contains(ch.CurrentHull));
                        }
-                        else
-                        {
-                            return null;
-                        }
+                        return null;
                    }
                }
            }
@@ -1497,7 +1503,7 @@ namespace Barotrauma
            if (hull == null || 
                hull.WaterPercentage > 90 || 
                hull.LethalPressure > 0 || 
-                hull.ConnectedGaps.Any(gap => !gap.IsRoomToRoom && gap.Open > 0.5f))
+                hull.ConnectedGaps.Any(gap => !gap.IsRoomToRoom && gap.Open > 0.9f))
            {
                needsSuit = !Character.HasAbilityFlag(AbilityFlags.ImmuneToPressure);
                return true;
@@ -30,6 +30,7 @@ namespace Barotrauma
                if (!character.Submarine.IsConnectedTo(item.Submarine)) { return false; }
            }
            if (item.ConditionPercentage <= 0) { return false; }
+            if (item.IsClaimedByBallastFlora) { return false; }
            if (Character.CharacterList.Any(c => c.CurrentHull == item.CurrentHull && !HumanAIController.IsFriendly(c) && HumanAIController.IsActive(c))) { return false; }
            if (IsReady(battery)) { return false; }
            return true;
@@ -83,7 +83,8 @@ namespace Barotrauma
            container.HasTag("allowcleanup") && 
            container.ParentInventory == null && container.OwnInventory != null && container.OwnInventory.AllItems.Any() && 
            container.GetComponent<ItemContainer>() != null &&
-            IsItemInsideValidSubmarine(container, character);
+            IsItemInsideValidSubmarine(container, character) &&
+            !container.IsClaimedByBallastFlora;

        public static bool IsValidTarget(Item item, Character character, bool checkInventory, bool allowUnloading = true)
        {
@@ -100,6 +101,7 @@ namespace Barotrauma
                if (!IsValidContainer(item.Container, character, allowUnloading)) { return false; }
            }
            if (character != null && !IsItemInsideValidSubmarine(item, character)) { return false; }
+            if (item.HasBallastFloraInHull) { return false; }
            var pickable = item.GetComponent<Pickable>();
            if (pickable == null) { return false; }
            if (pickable is Holdable h && h.Attachable && h.Attached) { return false; }
@@ -777,7 +777,7 @@ namespace Barotrauma
            }
            if (retreatTarget != null && character.CurrentHull != retreatTarget)
            {
-                TryAddSubObjective(ref retreatObjective, () => new AIObjectiveGoTo(retreatTarget, character, objectiveManager, false, true)
+                TryAddSubObjective(ref retreatObjective, () => new AIObjectiveGoTo(retreatTarget, character, objectiveManager)
                {
                    UsePathingOutside = false
                },
@@ -162,7 +162,6 @@ namespace Barotrauma
                    CloseEnough = reach,
                    DialogueIdentifier = Leak.FlowTargetHull != null ? "dialogcannotreachleak".ToIdentifier() : Identifier.Empty,
                    TargetName = Leak.FlowTargetHull?.DisplayName,
-                    CheckVisibility = false,
                    requiredCondition = () => Leak.Submarine == character.Submarine,
                    // The Go To objective can be abandoned if the leak is fixed (in which case we don't want to use the dialogue)
                    SpeakCannotReachCondition = () => !CheckObjectiveSpecific()
@@ -1,7 +1,6 @@
 using Microsoft.Xna.Framework;
 using System;
 using System.Collections.Generic;
-using System.Globalization;
 using System.Linq;
 using Barotrauma.Extensions;

@@ -11,6 +10,8 @@ namespace Barotrauma
    {
        public override Identifier Identifier { get; set; } = "go to".ToIdentifier();

+        public override bool KeepDivingGearOn => GetTargetHull() == null;
+
        private AIObjectiveFindDivingGear findDivingGear;
        private readonly bool repeat;
        //how long until the path to the target is declared unreachable
@@ -74,14 +75,6 @@ namespace Barotrauma
                _closeEnough = Math.Max(minDistance, value);
            }
        }
-
-        // TODO: Currently we never check the visibility (to the end node), which is actually unintentional.
-        // I don't think it has caused any issues so far, so let's keep defaulting to false for now, because the less we do raycasts the better.
-        // However, if there are cases where the bots attempt to go through walls (select the end node that is behind an obstacle), we should set this true.
-
-        // NOTE: This seemes to have caused an issue now Regalis11/Barotrauma#8067: namely, the bot was trying to use a waypoint that was obstructed by a shuttle
-        // because obstruction was only checked when checking visibility in PathFinder. Changed that so that obstructed nodes are no longer used.
-        public bool CheckVisibility { get; set; }
        public bool IgnoreIfTargetDead { get; set; }
        public bool AllowGoingOutside { get; set; }

@@ -268,15 +261,15 @@ namespace Barotrauma
                {
                    Character followTarget = Target as Character;
                    bool needsDivingSuit = (!isInside || hasOutdoorNodes) && character.NeedsAir && !character.HasAbilityFlag(AbilityFlags.ImmuneToPressure);
-                    bool needsDivingGear = (needsDivingSuit || HumanAIController.NeedsDivingGear(targetHull, out needsDivingSuit)) && character.NeedsAir;
+                    bool needsDivingGear = (needsDivingSuit || HumanAIController.NeedsDivingGear(targetHull, out needsDivingSuit));
                    if (Mimic)
                    {
-                        if (HumanAIController.HasDivingSuit(followTarget) && character.NeedsAir)
+                        if (HumanAIController.HasDivingSuit(followTarget))
                        {
                            needsDivingGear = true;
                            needsDivingSuit = true;
                        }
-                        else if (HumanAIController.HasDivingMask(followTarget) && character.NeedsAir)
+                        else if (HumanAIController.HasDivingMask(followTarget))
                        {
                            needsDivingGear = true;
                        }
@@ -505,7 +498,7 @@ namespace Barotrauma
                            startNodeFilter: n => (n.Waypoint.CurrentHull == null) == (character.CurrentHull == null),
                            endNodeFilter: endNodeFilter,
                            nodeFilter: nodeFilter,
-                            checkVisiblity: CheckVisibility);
+                            checkVisiblity: Target is Item || Target is Character);
                    }
                    if (!isInside && (PathSteering.CurrentPath == null || PathSteering.IsPathDirty || PathSteering.CurrentPath.Unreachable))
                    {
@@ -60,6 +60,7 @@ namespace Barotrauma
            if (targetCondition.HasValue && container.Inventory.IsFull() && container.Inventory.AllItems.None(i => ItemMatchesTargetCondition(i, targetCondition.Value))) { return false; }
            if (!AIObjectiveCleanupItems.IsItemInsideValidSubmarine(item, character)) { return false; }
            if (item.GetRootInventoryOwner() is Character owner && owner != character) { return false; }
+            if (item.IsClaimedByBallastFlora) { return false; }
            if (!item.HasAccess(character)) { return false; }
            // Ignore items that require power but don't have it
            if (item.GetComponent<Powered>() is Powered powered && powered.PowerConsumption > 0 && powered.Voltage < powered.MinVoltage) { return false; }
@@ -10,6 +10,16 @@ namespace Barotrauma
 {
    class AIObjectiveManager
    {
+        public enum ObjectiveType
+        {
+            None = 0,
+            Order = 1,
+            Objective = 2,
+            
+            MinValue = 0,
+            MaxValue = 2
+        }
+
        public const float HighestOrderPriority = 70;
        public const float LowestOrderPriority = 60;
        public const float RunPriority = 50;
@@ -184,28 +194,20 @@ namespace Barotrauma
        {
            var previousObjective = CurrentObjective;
            var firstObjective = Objectives.FirstOrDefault();
+            
            bool currentObjectiveIsOrder = CurrentOrder != null && firstObjective != null && CurrentOrder.Priority > firstObjective.Priority;
-            if (currentObjectiveIsOrder)
+            
+            CurrentObjective = currentObjectiveIsOrder ? CurrentOrder : firstObjective;
+
+            if (previousObjective == CurrentObjective) { return CurrentObjective; }
+
+            previousObjective?.OnDeselected();
+            CurrentObjective?.OnSelected();
+            GetObjective<AIObjectiveIdle>().CalculatePriority(Math.Max(CurrentObjective.Priority - 10, 0));
+            if (GameMain.NetworkMember is { IsServer: true })
            {
-                CurrentObjective = CurrentOrder;
-            }
-            else
-            {
-                CurrentObjective = firstObjective;
-            }
-            if (previousObjective != CurrentObjective)
-            {
-                previousObjective?.OnDeselected();
-                CurrentObjective?.OnSelected();
-                GetObjective<AIObjectiveIdle>().CalculatePriority(Math.Max(CurrentObjective.Priority - 10, 0));
-                if (GameMain.NetworkMember != null && GameMain.NetworkMember.IsServer)
-                {
-                    GameMain.NetworkMember.CreateEntityEvent(character, new object[]
-                    {
-                        NetEntityEvent.Type.ObjectiveManagerState,
-                        currentObjectiveIsOrder ? "order" : "objective"
-                    });
-                }
+                GameMain.NetworkMember.CreateEntityEvent(character,
+                    new Character.ObjectiveManagerStateEventData(currentObjectiveIsOrder ? ObjectiveType.Order : ObjectiveType.Objective));
            }
            return CurrentObjective;
        }
@@ -67,6 +67,11 @@ namespace Barotrauma
                    Priority = 0;
                    return Priority;
                }
+                else if (targetItem.IsClaimedByBallastFlora)
+                {
+                    Priority = 0;
+                    return Priority;
+                }
                var reactor = component?.Item.GetComponent<Reactor>();
                if (reactor != null)
                {
@@ -41,6 +41,7 @@ namespace Barotrauma
                if (!character.Submarine.IsConnectedTo(pump.Item.Submarine)) { return false; }
            }
            if (Character.CharacterList.Any(c => c.CurrentHull == pump.Item.CurrentHull && !HumanAIController.IsFriendly(c) && HumanAIController.IsActive(c))) { return false; }
+            if (pump.Item.IsClaimedByBallastFlora) { return false; }
            if (IsReady(pump)) { return false; }
            return true;
        }
@@ -1,7 +1,6 @@
 using Barotrauma.Items.Components;
 using Microsoft.Xna.Framework;
 using System;
-using System.Collections.Generic;
 using System.Linq;
 using Barotrauma.Extensions;

@@ -12,6 +11,7 @@ namespace Barotrauma
        public override Identifier Identifier { get; set; } = "repair item".ToIdentifier();

        public override bool AllowInAnySub => true;
+        public override bool KeepDivingGearOn => Item?.CurrentHull == null;

        public Item Item { get; private set; }

@@ -52,6 +52,10 @@ namespace Barotrauma
                Priority = 0;
                IsCompleted = true;
            }
+            else if (Item.IsClaimedByBallastFlora)
+            {
+                Priority = 0;
+            }
            else
            {
                float distanceFactor = 1;
@@ -151,6 +151,7 @@ namespace Barotrauma
            if (!item.IsInteractable(character)) { return false; }
            if (item.IsFullCondition) { return false; }
            if (item.Submarine == null || character.Submarine == null) { return false; }
+            if (item.IsClaimedByBallastFlora) { return false; } 
            //player crew ignores items in outposts
            if (character.IsOnPlayerTeam && item.Submarine.Info.IsOutpost) { return false; }
            if (!character.Submarine.IsEntityFoundOnThisSub(item, includingConnectedSubs: true)) { return false; }
@@ -30,6 +30,7 @@ namespace Barotrauma
        private float findHullTimer;
        private bool ignoreOxygen;
        private readonly float findHullInterval = 1.0f;
+        private bool performedCpr;

        public AIObjectiveRescue(Character character, Character targetCharacter, AIObjectiveManager objectiveManager, float priorityModifier = 1) 
            : base(character, objectiveManager, priorityModifier)
@@ -220,12 +221,12 @@ namespace Barotrauma
                    DialogueIdentifier = "dialogcannotreachpatient".ToIdentifier(),
                    TargetName = targetCharacter.DisplayName
                },
-                    onCompleted: () => RemoveSubObjective(ref goToObjective),
-                    onAbandon: () =>
-                    {
-                        RemoveSubObjective(ref goToObjective);
-                        Abandon = true;
-                    });
+                onCompleted: () => RemoveSubObjective(ref goToObjective),
+                onAbandon: () =>
+                {
+                    RemoveSubObjective(ref goToObjective);
+                    Abandon = true;
+                });
            }
            else
            {
@@ -401,6 +402,7 @@ namespace Barotrauma
                {
                    character.SelectCharacter(targetCharacter);
                    character.AnimController.Anim = AnimController.Animation.CPR;
+                    performedCpr = true;
                }
                else
                {
@@ -436,9 +438,10 @@ namespace Barotrauma
        {
            bool isCompleted = AIObjectiveRescueAll.GetVitalityFactor(targetCharacter) >= AIObjectiveRescueAll.GetVitalityThreshold(objectiveManager, character, targetCharacter);
            if (isCompleted && targetCharacter != character && character.IsOnPlayerTeam)
-            {                
-                character.Speak(TextManager.GetWithVariable("DialogTargetHealed", "[targetname]", targetCharacter.Name).Value,
-                    null, 1.0f, $"targethealed{targetCharacter.Name}".ToIdentifier(), 60.0f);
+            {
+                string textTag = performedCpr ? "DialogTargetResuscitated" : "DialogTargetHealed";
+                string message = TextManager.GetWithVariable(textTag, "[targetname]", targetCharacter.Name)?.Value;
+                character.Speak(message, delay: 1.0f, identifier: $"targethealed{targetCharacter.Name}".ToIdentifier(), minDurationBetweenSimilar: 60.0f);
            }
            return isCompleted;
        }
@@ -392,7 +392,6 @@ namespace Barotrauma
            return option;
        }

-        
        public ImmutableArray<Identifier> GetTargetItems(Identifier option = default)
        {
            if (option.IsEmpty || !OptionTargetItems.TryGetValue(option, out ImmutableArray<Identifier> optionTargetItems))
@@ -418,6 +417,28 @@ namespace Barotrauma
        }
        
        public override void Dispose() { }
+
+        /// <summary>
+        /// Create an Order instance with a null target
+        /// </summary>
+        public Order CreateInstance(OrderTargetType targetType, Character orderGiver = null, bool isAutonomous = false)
+        {
+            try
+            {
+                return targetType switch
+                {
+                    OrderTargetType.Entity => new Order(this, targetEntity: null, targetItem: null, orderGiver, isAutonomous),
+                    OrderTargetType.Position => new Order(this, target: null, orderGiver),
+                    OrderTargetType.WallSection => new Order(this, wall: null, sectionIndex: null, orderGiver),
+                    _ => throw new NotImplementedException()
+                };
+            }
+            catch (NotImplementedException e)
+            {
+                DebugConsole.ShowError($"Error creating a new Order instance: unexpected target type \"{targetType}\".\n{e.StackTrace.CleanupStackTrace()}");
+                return null;
+            }
+        }
    }

    class Order
@@ -510,28 +531,45 @@ namespace Barotrauma
        public readonly bool UseController;

        /// <summary>
-        /// Constructor for order instances
+        /// Constructor for orders with the target type OrderTargetType.Entity
        /// </summary>
        public Order(OrderPrefab prefab, Entity targetEntity, ItemComponent targetItem, Character orderGiver = null, bool isAutonomous = false)
            : this(prefab, Identifier.Empty, 0, OrderType.Current, null, targetEntity, targetItem, orderGiver, isAutonomous) { }

-
+        /// <summary>
+        /// Constructor for orders with the target type OrderTargetType.Entity
+        /// </summary>
        public Order(OrderPrefab prefab, Identifier option, Entity targetEntity, ItemComponent targetItem, Character orderGiver = null, bool isAutonomous = false)
            : this(prefab, option, 0, OrderType.Current, null, targetEntity, targetItem, orderGiver, isAutonomous) { }

+        /// <summary>
+        /// Constructor for orders with the target type OrderTargetType.Position
+        /// </summary>
        public Order(OrderPrefab prefab, OrderTarget target, Character orderGiver = null)
            : this(prefab, prefab.Options.FirstOrDefault(), 0, OrderType.Current, null, target, orderGiver) { }

+        /// <summary>
+        /// Constructor for orders with the target type OrderTargetType.Position
+        /// </summary>
        public Order(OrderPrefab prefab, Identifier option, OrderTarget target, Character orderGiver = null)
            : this(prefab, option, 0, OrderType.Current, null, target, orderGiver) { }

+        /// <summary>
+        /// Constructor for orders with the target type OrderTargetType.WallSection
+        /// </summary>
        public Order(OrderPrefab prefab, Structure wall, int? sectionIndex, Character orderGiver = null)
            : this(prefab, Identifier.Empty, 0, OrderType.Current, null, wall, sectionIndex, orderGiver) { }

+        /// <summary>
+        /// Constructor for orders with the target type OrderTargetType.WallSection
+        /// </summary>
        public Order(OrderPrefab prefab, Identifier option, Structure wall, int? sectionIndex, Character orderGiver = null)
            : this(prefab, option, 0, OrderType.Current, null, wall, sectionIndex, orderGiver) { }

-        public Order(OrderPrefab prefab, Identifier option, int manualPriority, OrderType orderType, AIObjective aiObjective, Entity targetEntity, ItemComponent targetItem, Character orderGiver = null, bool isAutonomous = false)
+        /// <summary>
+        /// Constructor for orders with the target type OrderTargetType.Entity
+        /// </summary>
+        private Order(OrderPrefab prefab, Identifier option, int manualPriority, OrderType orderType, AIObjective aiObjective, Entity targetEntity, ItemComponent targetItem, Character orderGiver = null, bool isAutonomous = false)
        {
            Prefab = prefab;
            Option = option;
@@ -561,14 +599,20 @@ namespace Barotrauma
            TargetType = OrderTargetType.Entity;
        }

-        public Order(OrderPrefab prefab, Identifier option, int manualPriority, OrderType orderType, AIObjective aiObjective, OrderTarget target, Character orderGiver = null)
+        /// <summary>
+        /// Constructor for orders with the target type OrderTargetType.Position
+        /// </summary>
+        private Order(OrderPrefab prefab, Identifier option, int manualPriority, OrderType orderType, AIObjective aiObjective, OrderTarget target, Character orderGiver = null)
            : this(prefab, option, manualPriority, orderType, aiObjective, targetEntity: null, targetItem: null, orderGiver)
        {
            TargetPosition = target;
            TargetType = OrderTargetType.Position;
        }

-        public Order(OrderPrefab prefab, Identifier option, int manualPriority, OrderType orderType, AIObjective aiObjective, Structure wall, int? sectionIndex, Character orderGiver = null)
+        /// <summary>
+        /// Constructor for orders with the target type OrderTargetType.WallSection
+        /// </summary>
+        private Order(OrderPrefab prefab, Identifier option, int manualPriority, OrderType orderType, AIObjective aiObjective, Structure wall, int? sectionIndex, Character orderGiver = null)
            : this(prefab, option, manualPriority, orderType, aiObjective, targetEntity: wall, null, orderGiver: orderGiver)
        {
            WallSectionIndex = sectionIndex;
@@ -633,7 +677,7 @@ namespace Barotrauma

        public Order WithTargetEntity(Entity entity)
        {
-            return new Order(this, targetEntity: entity);
+            return new Order(this, targetEntity: entity, targetType: OrderTargetType.Entity);
        }

        public Order WithTargetSpatialEntity(ISpatialEntity spatialEntity)
@@ -673,7 +717,7 @@ namespace Barotrauma

        public Order WithTargetPosition(OrderTarget targetPosition)
        {
-            return new Order(this, targetPosition: targetPosition);
+            return new Order(this, targetPosition: targetPosition, targetType: OrderTargetType.Position);
        }

        public Order Clone()
@@ -313,8 +313,7 @@ namespace Barotrauma
                        ShipCommandLog("Dismissing " + shipIssueWorker + " for character " + shipIssueWorker.OrderedCharacter);
 #endif
                        var order = new Order(OrderPrefab.Dismissal, null).WithManualPriority(3).WithOrderGiver(character);
-                        //character.Speak(orderPrefab.GetChatMessage(shipIssueWorker.OrderedCharacter.Name, "", givingOrderToSelf: false));
-                        shipIssueWorker.OrderedCharacter.SetOrder(order);
+                        shipIssueWorker.OrderedCharacter.SetOrder(order, isNewOrder: true);
                        shipIssueWorker.RemoveOrder();
                        break;
                    }
@@ -368,7 +367,7 @@ namespace Barotrauma
            ShipGlobalIssueFixLeaks shipGlobalIssueFixLeaks = new ShipGlobalIssueFixLeaks(this);
            for (int i = 0; i < crewSizeModifier; i++)
            {
-                var order = new Order(OrderPrefab.Prefabs["fixleaks"], null);
+                var order = OrderPrefab.Prefabs["fixleaks"].CreateInstance(OrderPrefab.OrderTargetType.Entity);
                ShipIssueWorkers.Add(new ShipIssueWorkerFixLeaks(this, order, shipGlobalIssueFixLeaks));
            }
            shipGlobalIssues.Add(shipGlobalIssueFixLeaks);
@@ -376,7 +375,7 @@ namespace Barotrauma
            ShipGlobalIssueRepairSystems shipGlobalIssueRepairSystems = new ShipGlobalIssueRepairSystems(this);
            for (int i = 0; i < crewSizeModifier; i++)
            {
-                var order = new Order(OrderPrefab.Prefabs["repairsystems"], null);
+                var order = OrderPrefab.Prefabs["repairsystems"].CreateInstance(OrderPrefab.OrderTargetType.Entity);
                ShipIssueWorkers.Add(new ShipIssueWorkerRepairSystems(this, order, shipGlobalIssueRepairSystems));
            }
            shipGlobalIssues.Add(shipGlobalIssueRepairSystems);
@@ -442,7 +442,7 @@ namespace Barotrauma
        }

 #if SERVER
-        public void ServerWrite(IWriteMessage msg, Client client, object[] extraData = null)
+        public void ServerEventWrite(IWriteMessage msg, Client client, NetEntityEvent.IData extraData = null)
        {
            msg.Write(IsAlive);
        }