Items removed due to the "DeleteOnUse" property are removed using EntitySpawner, removing an item removes it from the selected items of all characters. Closes #306

Barotrauma/BarotraumaShared/Source/Items/CharacterInventory.cs

@@ -50,7 +50,14 @@ namespace Barotrauma
             }
 
             Items[slotIndex].ApplyStatusEffects(ActionType.OnUse, 1.0f, character);
-
+            foreach (ItemComponent ic in Items[slotIndex].components)
+            {
+                if (ic.DeleteOnUse)
+                {
+                    Entity.Spawner.AddToRemoveQueue(Items[slotIndex]);
+                }
+            }
+            
             return true;
         }
         

Barotrauma/BarotraumaShared/Source/Items/Components/Holdable/MeleeWeapon.cs

@@ -288,6 +288,11 @@ namespace Barotrauma.Items.Components
             if (targetCharacter != null) //TODO: Allow OnUse to happen on structures too maybe??
                 ApplyStatusEffects(ActionType.OnUse, 1.0f, targetCharacter != null ? targetCharacter : null);
 
+            if (DeleteOnUse)
+            {
+                Entity.Spawner.AddToRemoveQueue(item);
+            }
+
             return true;
         }
     }

Barotrauma/BarotraumaShared/Source/Items/Item.cs

@@ -1166,7 +1166,10 @@ namespace Barotrauma
                 }
             }
 
-            if (remove) Remove();
+            if (remove)
+            {
+                Spawner.AddToRemoveQueue(this);
+            }
         }
 
         public void SecondaryUse(float deltaTime, Character character = null)
@@ -1845,7 +1848,16 @@ namespace Barotrauma
         public override void Remove()
         {
             base.Remove();
-            
+
+            foreach (Character character in Character.CharacterList)
+            {
+                if (character.SelectedConstruction == this) character.SelectedConstruction = null;
+                for (int i = 0; i < character.SelectedItems.Length; i++)
+                {
+                    if (character.SelectedItems[i] == this) character.SelectedItems[i] = null;
+                }
+            }
+
             if (parentInventory != null)
             {
                 parentInventory.RemoveItem(this);