[In-Progress] Plugin system rewrite.

Game starts up, runs until unimplemented functions are reached without errors.

Barotrauma/BarotraumaShared/SharedSource/LuaCs/Services/_Interfaces/IAssemblyManagementService.cs

@@ -6,41 +6,33 @@ using System.Reflection;
 using System.Runtime.CompilerServices;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp;
+using OneOf;
+
 // ReSharper disable InconsistentNaming
 
 namespace Barotrauma.LuaCs.Services;
 
 public interface IAssemblyManagementService : IReusableService
 {
-    /// <summary>
-    /// Searches for an assembly given it's fully qualified name, while excluding the contexts with the given Guids, if supplied.
-    /// </summary>
-    /// <param name="assemblyName">The fully-qualified assembly name.</param>
-    /// <param name="excludedContexts">Guids of excluded contexts.</param>
-    /// <returns><b>On Success:</b> The assembly. <br/><b>On Failure:</b> nothing.</returns>
-    FluentResults.Result<Assembly> GetLoadedAssembly(string assemblyName, in Guid[] excludedContexts);
+
     /// <summary>
     /// Searches for an assembly given it's fully qualified name, while excluding the contexts with the given Guids, if supplied.
     /// </summary>
     /// <param name="assemblyName">The assembly info.</param>
     /// <param name="excludedContexts">Guids of excluded contexts.</param>
     /// <returns><b>On Success:</b> The assembly. <br/><b>On Failure:</b> nothing.</returns>
-    FluentResults.Result<Assembly> GetLoadedAssembly(AssemblyName assemblyName, in Guid[] excludedContexts);
+    FluentResults.Result<Assembly> GetLoadedAssembly(OneOf<AssemblyName, string> assemblyName, in Guid[] excludedContexts);
     
     /// <summary>
-    /// Gets the assembly <see cref="MetadataReference"/> collection for the BCL and base game assemblies. 
+    /// Gets all <see cref="MetadataReference"/> for all service-managed assemblies.
     /// </summary>
-    /// <returns><see cref="MetadataReference"/> collection, if any are found. Returns an empty collection otherwise.</returns>
-    ImmutableArray<MetadataReference> GetDefaultMetadataReferences();
+    /// <returns><see cref="MetadataReference"/> collection for all service-managed, and default if selected, assemblies, if any are found. Returns an empty collection otherwise.</returns>
+    ImmutableArray<MetadataReference> GetDefaultMetadataReferences(bool includeDefaultContext = true);
     
     /// <summary>
-    /// Gets the assembly <see cref="MetadataReference"/> collection for all add-in assemblies loaded.
-    /// </summary>
-    /// <returns><see cref="MetadataReference"/> collection, if any are found. Returns an empty collection otherwise.</returns>
-    ImmutableArray<MetadataReference> GetAddInContextsMetadataReferences();
-    
-    /// <summary>
-    /// 
+    /// Returns all active, managed assembly loaders.
     /// </summary>
     ImmutableArray<IAssemblyLoaderService> AssemblyLoaderServices { get; }
+    
+    
 }

Barotrauma/BarotraumaShared/SharedSource/LuaCs/Services/_Interfaces/IPluginManagementService.cs

@@ -10,33 +10,27 @@ namespace Barotrauma.LuaCs.Services;
 public interface IPluginManagementService : IReusableService
 {
     /// <summary>
-    /// Checks if the supplied resource is currently loaded.
+    /// Gets all  types in searched <see cref="IAssemblyLoaderService"/> that implement the type supplied.
     /// </summary>
-    /// <param name="resource">The resource to check.</param>
-    /// <returns></returns>
-    bool IsResourceLoaded<T>(T resource) where T : IAssemblyResourceInfo;
-    
-    /// <summary>
-    /// 
-    /// </summary>
-    /// <param name="namespacePrefix"></param>
     /// <param name="includeInterfaces"></param>
     /// <param name="includeAbstractTypes"></param>
     /// <param name="includeDefaultContext"></param>
     /// <typeparam name="T"></typeparam>
     /// <returns></returns>
     FluentResults.Result<ImmutableArray<Type>> GetImplementingTypes<T>(
-        string namespacePrefix = null,
         bool includeInterfaces = false,
         bool includeAbstractTypes = false,
         bool includeDefaultContext = true);
     
     /// <summary>
-    /// Tries to get the Type given the fully qualified name.
+    /// Tries to find the type given the fully qualified name and filters.
     /// </summary>
     /// <param name="typeName"></param>
+    /// <param name="isByRefType"></param>
+    /// <param name="includeInterfaces"></param>
+    /// <param name="includeDefaultContext"></param>
     /// <returns></returns>
-    Type GetType(string typeName);
+    Type GetType(string typeName, bool isByRefType = false, bool includeInterfaces = false, bool includeDefaultContext = true);
 
     /// <summary>
     /// Loads the provided assembly resources in the order of their dependencies and intra-mod priority load order.
@@ -56,11 +50,9 @@ public interface IPluginManagementService : IReusableService
     IReadOnlyList<FluentResults.Result<(Type, T)>> ActivateTypeInstances<T>(ImmutableArray<Type> types, bool serviceInjection = true,
         bool hostInstanceReference = false) where T : IDisposable;
     
-    FluentResults.Result UnloadHostedReferences();
-
     /// <summary>
-    /// Tries to gracefully unload all hosted plugin references 
+    /// Unloads all managed <see cref="IAssemblyPlugin"/>, <see cref="Assembly"/>, and <see cref="IAssemblyLoaderService"/>s.
     /// </summary>
-    /// <returns></returns>
-    FluentResults.Result UnloadAllAssemblyResources();
+    /// <returns>Success of the operation. <br/><b>Note: does not guarantee .NET runtime assembly unloading success.<b/></returns>
+    FluentResults.Result UnloadManagedAssemblies();
 }