Fabricator, deconstructor, itemspawner & itemremover syncing, fixed placing hulls in editor, misc cleanup

Subsurface/Source/Networking/GameClient.cs

@@ -95,7 +95,7 @@ namespace Barotrauma.Networking
             {
                 IPEndPoint = new System.Net.IPEndPoint(NetUtility.Resolve(serverIP), Port);
             }
-            catch (Exception e)
+            catch
             {
                 new GUIMessageBox("Could not connect to server", "Failed to resolve address ''"+serverIP+":"+Port+"''. Please make sure you have entered a valid IP address.");
                 return;
@@ -519,6 +519,12 @@ namespace Barotrauma.Networking
                     case  (byte)PacketTypes.VoteStatus:
                         Voting.ReadData(inc);
                         break;
+                    case (byte)PacketTypes.NewItem:
+                        Item.Spawner.ReadNetworkData(inc);
+                        break;
+                    case (byte)PacketTypes.RemoveItem:
+                        Item.Remover.ReadNetworkData(inc);
+                        break;
                 }                
             }
         }

Subsurface/Source/Networking/GameServer.cs

@@ -1264,6 +1264,29 @@ namespace Barotrauma.Networking
             message.Write(character.Info.Job.Name);
         }
 
+        public void SendItemSpawnMessage(List<Item> items, List<Inventory> inventories = null)
+        {
+            if (items == null || !items.Any()) return;
+
+            NetOutgoingMessage message = server.CreateMessage();
+            message.Write((byte)PacketTypes.NewItem);
+
+            Item.Spawner.FillNetworkData(message, items, inventories);
+
+            SendMessage(message, NetDeliveryMethod.ReliableUnordered);
+        }
+
+        public void SendItemRemoveMessage(List<Item> items)
+        {
+            if (items == null || !items.Any()) return;
+
+            NetOutgoingMessage message = server.CreateMessage();
+
+            Item.Remover.FillNetworkData(message, items);
+
+            SendMessage(message, NetDeliveryMethod.ReliableUnordered);
+        }
+
         private void AssignJobs()
         {
             List<Client> unassigned = new List<Client>(ConnectedClients);
@@ -1305,16 +1328,7 @@ namespace Barotrauma.Networking
                     if (assignedClientCount[i] < JobPrefab.List[i].MinNumber) unassignedJobsFound = true;
                 }
             }
-
-            //share the rest of the jobs according to the ''commonness'' of the job
-            //float totalCommonness = 0.0f;
-            //for (int i = 0; i < JobPrefab.List.Count; i++)
-            //{
-            //    if (JobPrefab.List[i].AllowAlways || JobPrefab.List[i].MaxNumber == 0) continue;
-
-            //    totalCommonness += JobPrefab.List[i].Commonness;
-            //}
-
+            
             //find a suitable job for the rest of the players
             for (int i = unassigned.Count - 1; i >= 0; i--)
             {

Subsurface/Source/Networking/NetworkEvent.cs

@@ -167,7 +167,7 @@ namespace Barotrauma.Networking
                 }
                 catch
                 {
-                    int afghj = 1;
+                    
                 }
                 //+1 because msgLength is one additional byte
                 currPos += msgLength + 1;

Subsurface/Source/Networking/NetworkMember.cs

@@ -19,6 +19,8 @@ namespace Barotrauma.Networking
 
         StartGame, EndGame,
 
+        NewItem, RemoveItem,
+
         CharacterInfo,
 
         Chatmessage, UpdateNetLobby,