- Some work on PluginManagementService, IAssemblyLoaderService and IAssemblyManagementService refactors.

- Fixed mod list sync not checking for zero package diff length.
- Fixed the services provider not being able to inject itself as a dependcency.
- Added UseInternalName data spec to ModConfig.xml
- Changed Basic.Reference.Assemblies to Net80.

Barotrauma/BarotraumaShared/SharedSource/LuaCs/_Plugins/AssemblyLoader.cs

@@ -24,6 +24,20 @@ using Path = System.IO.Path;
 namespace Barotrauma.LuaCs.Services;
 public sealed class AssemblyLoader : AssemblyLoadContext, IAssemblyLoaderService
 {
+    public class Factory : IAssemblyLoaderService.IFactory
+    {
+        public IAssemblyLoaderService CreateInstance(IAssemblyLoaderService.LoaderInitData initData)
+        {
+            return new AssemblyLoader(initData);
+        }
+
+        public void Dispose()
+        {
+            //stateless service
+        }
+        public bool IsDisposed => false;
+    }
+    
     public Guid Id { get; init; }
     public ContentPackage OwnerPackage { get; private set; }
     public bool IsReferenceOnlyMode { get; init; }
@@ -55,7 +69,6 @@ public sealed class AssemblyLoader : AssemblyLoadContext, IAssemblyLoaderService
     private int _operationsRunning;
     
     //internal
-    private readonly IAssemblyManagementService _assemblyManagementService;
     private readonly Action<IAssemblyLoaderService> _onUnload;
     private readonly Func<IAssemblyLoaderService, AssemblyName, Assembly> _onResolvingManaged;
     private readonly Func<Assembly, string, IntPtr> _onResolvingUnmanagedDll;
@@ -68,7 +81,6 @@ public sealed class AssemblyLoader : AssemblyLoadContext, IAssemblyLoaderService
     public AssemblyLoader(IAssemblyLoaderService.LoaderInitData initData) 
         : base(isCollectible: true, name: initData.Name)
     {
-        _assemblyManagementService = initData.AssemblyManagementService;
         Id = initData.InstanceId;
         IsReferenceOnlyMode = initData.IsReferenceMode;
         this._onUnload = initData.OnUnload;
@@ -217,7 +229,10 @@ public sealed class AssemblyLoader : AssemblyLoadContext, IAssemblyLoaderService
                 try
                 {
                     var p = Path.GetFullPath(path.CleanUpPath());
-                    _dependencyResolvers[p] = new AssemblyDependencyResolver(p);
+                    if (!_dependencyResolvers.ContainsKey(p))
+                    {
+                        _dependencyResolvers[p] = new AssemblyDependencyResolver(p);
+                    }                        
                 }
                 catch (Exception ex)
                 {

Barotrauma/BarotraumaShared/SharedSource/LuaCs/_Plugins/IAssemblyLoaderService.cs

@@ -13,6 +13,11 @@ namespace Barotrauma.LuaCs;
 
 public interface IAssemblyLoaderService : IService
 {
+    public interface IFactory : IService
+    {
+        IAssemblyLoaderService CreateInstance(LoaderInitData initData);
+    }
+    
     /// <summary>
     /// Constructor record for instancing.
     /// </summary>
@@ -26,7 +31,6 @@ public interface IAssemblyLoaderService : IService
     /// <param name="OnResolvingManaged"></param>
     /// <param name="OnResolvingUnmanagedDll"></param>
     public record LoaderInitData(
-        [Required][NotNull] IAssemblyManagementService AssemblyManagementService,
         [Required] Guid InstanceId,
         [Required][NotNull] string Name,
         [Required] bool IsReferenceMode,